Revapi: Fix order in the revapi file#16511
Merged
Merged
Conversation
nastra
reviewed
May 21, 2026
| old: "method org.apache.iceberg.orc.ORC.WriteBuilder org.apache.iceberg.orc.ORC.WriteBuilder::config(java.lang.String,\ | ||
| \ java.lang.String)" | ||
| justification: "Removing deprecations for 1.2.0" | ||
| "1.10.0": |
Contributor
There was a problem hiding this comment.
do we know why revapi forces a different ordering now?
Contributor
There was a problem hiding this comment.
apparently this has been a known issue for a while: palantir/gradle-revapi#651
I'm just curious why we started to see this issue more recently and not already 2 years ago
Contributor
Author
There was a problem hiding this comment.
I have no idea. I suspect that there was some initial manual revapi editing for 1.10.0 and then for the subsequent changes everyone just manually made it to be not relocated. Just speculating, though.
nastra
approved these changes
May 21, 2026
Contributor
Author
|
thanks for taking a look, @nastra ! |
aihuaxu
pushed a commit
to aihuaxu/iceberg
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running revapi, it reorders the versions. To avoid noise in other PRs, ran revapi on a clean main.