Core: Fix SerializableTable.sortOrders() throwing on historical sort orders with dropped fields (#16519)#16521
Open
MonkeyCanCode wants to merge 2 commits into
Open
Core: Fix SerializableTable.sortOrders() throwing on historical sort orders with dropped fields (#16519)#16521MonkeyCanCode wants to merge 2 commits into
MonkeyCanCode wants to merge 2 commits into
Conversation
MonkeyCanCode
changed the title
Author
|
@aihuaxu mind take a look? |
Author
|
Thanks for the quick review @anuragmantri . Mind take another look? |
anuragmantri
approved these changes
May 22, 2026
Author
|
@RussellSpitzer mind take a look if this is okay to proceed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
After upgraded Apache Iceberg runtime from 1.10.1 to 1.11.0, the write from spark on my workload started to fail when the table has a historical sort order that references a column that has since been dropped from the schema. This is introduced by #15150. This is also reported by @aihuaxu via #16519
Change
SerializableTable.sortOrders()strict binds every sort order against the current schema, which fails when a historical sort order references a field dropped by schema evolution. This PR fixes it to only strict bind the default sort order.Test Plan
I added the new test case added by @aihuaxu from #16519 as well as the local reproducible that I wrote to validate the issue is resolved by this PR.