Spark: time-travel filter fails on renamed columns in BaseDistributedDataScan#16523
Open
lilei1128 wants to merge 1 commit into
Open
Spark: time-travel filter fails on renamed columns in BaseDistributedDataScan#16523lilei1128 wants to merge 1 commit into
lilei1128 wants to merge 1 commit into
Conversation
Contributor
Author
|
close #16510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing time-travel reads with a filter on a column that was
subsequently renamed, a ValidationException was thrown:
"Cannot find field 'col' in struct: struct<..., 2: value: ...>"
Root cause: BaseDistributedDataScan.specCache() called table().specs()
directly, which returns partition specs bound to the current table schema.
When the filter expression was projected via Projections.inclusive() in
newManifestEvaluator(), it tried to resolve column names against the
current schema instead of the snapshot schema, causing the failure.
Fix:
consistent with DataTableScan
partition specs are re-bound to the snapshot schema during time-travel
the requested snapshot when snapshot-id is passed via options, as a
defensive fix for cases where SparkTable is not constructed with a
snapshotId field