Skip to content

KNOX-3297: Docker entrypoint script has issues that prevents this image being run as docker container and as a pod in k8s#1197

Open
sneethiraj wants to merge 5 commits intoapache:masterfrom
sneethiraj:master
Open

KNOX-3297: Docker entrypoint script has issues that prevents this image being run as docker container and as a pod in k8s#1197
sneethiraj wants to merge 5 commits intoapache:masterfrom
sneethiraj:master

Conversation

@sneethiraj
Copy link
Copy Markdown
Member

(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)

KNOX-3297: Docker entrypoint script has issues that prevents this image being run as docker container and as a pod in k8s

What changes were proposed in this pull request?

  1. Modified to use keytool from the PATH instead of hardcoding it.
  2. Fixed a scripting error related to default init of MASTER_S... environment variable.
  3. Added additional validation for file existance before additing it to truststore. Also, introduced a custom env variable TRUSTSTORE_IMPORTS to allow customers to add more number of certificates into truststore.

How was this patch tested?

  1. Validated the changes as standalone docker [run]
  2. Validated by running the docker image as k8s pod

(Please explain how this patch was tested. For instance: running automated unit/integration tests, manual tests. Please write down your test steps as detailed as possible)

Integration Tests

no new integration tests.

UI changes

None.

Please review Knox Contributing Process before opening a pull request.

@github-actions
Copy link
Copy Markdown

Test Results

16 tests   16 ✅  1s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit d8569eb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant