Repository navigation
feat(pr-management): record FIXUP as a code-review session outcome - #2056
Merged
Merged
Conversation
`code-review session record --outcome` accepted only the three GitHub review events plus skip / slop / dry-run outcomes, so a PR that ended on the FIXUP disposition (maintainer fixup pushed to the branch, then an APPROVE that explains it) could not be recorded, and the session summary under-counted the pass. Add `FIXUP` to the outcomes, count it as a review in the summary line, and say in review-flow Step 9 and the session-summary doc which dispositions map to which outcome. Generated-by: Claude Opus 5
potiuk
enabled auto-merge (squash)
November 10, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-review session record --outcomeacceptsAPPROVE,REQUEST_CHANGES,COMMENT,skipped,slop-comment,slop-closeanddry-run. A PR that ends on theFIXUPdisposition, where the maintainer pushes a fixup to the branch and then approves (classifications/disposition-fixup.md), has no outcome to record. The command refuses it, and the Step 3 summary under-counts the pass. Two such PRs went unrecorded in a recent review session.session.py: addsFIXUPtoOUTCOMESand counts it as a review. The summary line now readsReviewed: N (APPROVE a, REQUEST_CHANGES r, COMMENT c, FIXUP f).review-flow.mdStep 9: says which outcome each posted review maps to, withFIXUPcovering fixup-then-approve with or without auto-merge.session-summary.md: notes that aFIXUPcounts as a review.plugins/magpie-security-tools/is regenerated withcheck-family-plugins.py --fix.test_session_records_fixup_as_a_review.uv run --project tools/pr-management pytest: 806 passed. prek is clean on the changed files.🤖 Generated with Claude Code