Repository navigation
Conversation
The pr_link.py and typed_decision_prefilter.py commands pointed at <framework>/skills/pr-management-triage/scripts/. On a marketplace install <framework> is ~/.cache/apache-magpie/framework/current, which holds tools/ and no skills/, so both commands fail with "No such file". Use <skill-dir>/scripts/, the placeholder isolated-setup-doctor already uses, which resolves on every install method. Signed-off-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> Generated-by: Claude Code (Fable 5.2)
github-actions
Bot
added
family:pr-management
Kaap10
approved these changes
Nov 13, 2026
Kaap10
left a comment
Kaap10
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Clean and necessary fix.
Switching to <skill-dir>/scripts/ cleanly resolves the missing script failure on marketplace installs and matches the existing pattern in isolated-setup-doctor. Frontmatter token restamp is verified and CI is all green.
Doing the other four skills and adding <skill-dir> to AGENTS.md in a follow-up makes total sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-triagetold the agent to run its two bundled helpers from<framework>/skills/pr-management-triage/scripts/. On a marketplace install<framework>is~/.cache/apache-magpie/framework/current, which holdstools/and noskills/, so both commands fail with "No such file".<skill-dir>/scripts/, the placeholderisolated-setup-doctoralready uses. It resolves on every install method.Type of change
.claude/skills/<name>/) — eval fixtures updated belowTest plan
prek runon the two changed files passes (after refreshing themeasured_tokensstamp)0.9.0.dev202611101307, rantyped_decision_prefilter.pyfrom the skill's ownscripts/directory against a synthetic PR. It returned a prediction and wrote the telemetry record.ls ~/.cache/apache-magpie/framework/current/shows onlyplugins/andtools/.No new eval fixture: the change is a path in a command block, not skill behaviour.
RFC-AI-0004 compliance
check-placeholderspassesLinked issues
None.
Notes for reviewers (optional)
Four other skills use the same
<framework>/skills/<name>/scripts/form and have the same gap on marketplace installs:workflow-optimization,model-verify,setupstatus, andwrite-skill. I left them out. Thesetup-statuseval fixtures pinpython3 .apache-magpie/skills/setup-status/scripts/collect_status.py, so that one needs fixture changes and a decision on the expected command. I can follow up once the placeholder choice here is agreed.<skill-dir>has no row in theAGENTS.mdplaceholder table yet. Each use defines it inline, assetupdoes.Refs #2023, which noted this gap.
Generated-by: Claude Code (Fable 5.2), reviewed by
shahar1before submission