Repository navigation
fix(nsh): preserve error boundary handling after reset - #6869
Merged
Merged
Conversation
Backport the boundary fix from longbridge/nsh#1955. Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore error reporting after a component error boundary is reset. If a child fails again, the nearest active boundary shows its fallback. Backports the fix from longbridge/nsh#1955, following #6865.
Verification
cargo test --locked --manifest-path third-party/nsh/Cargo.toml -p nsh-core --lib: 1491 passed, 12 ignored. The existing error boundary test covers a second failure after reset.git diff --checkpassed. Desktop UI and product type checks were not run.AI use
OpenAI Codex implemented and verified the backport.
Checklist
Does this PR entail a change in behavior?