refactor(core): route reqsign send via accessor http client#7234
Merged
refactor(core): route reqsign send via accessor http client#7234
Conversation
Merged
Member
Author
|
Need to address wasm build failure |
Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Services that use reqsign currently wire signing and credential-fetch traffic through a global default reqwest client. This bypasses accessor-level HTTP client injection and makes reqsign traffic inconsistent with OpenDAL's HTTP abstraction.
Since
reqsign 3.0.0is now available, this PR updates the integration to the new API shape and keeps the accessor-driven HTTP path working across native and wasm targets.What changes are included in this PR?
AccessorInfoHttpSendinopendal-coreHTTP utilities.reqsign_core::HttpSendfor:HttpClientAccessorInfoHttpSend(delegates toAccessorInfo::http_client()at send time)s3,gcs,oss,obs,cos,azblob,azdls,azfilecoreservices to3.0.0.3.0.0API.reqsign-google 3.0.0.reqwest::Urltourl::Url, and remove the directreqwestdependency fromopendal-service-s3.core/Cargo.lockaccordingly.Validation:
cargo fmt --checkcargo check --all-featurescargo clippy --all-targets --all-features -- -D warningscargo build --target wasm32-unknown-unknown --no-default-features --features='services-azblob services-gdrive services-opfs services-s3 layers-metrics' --lockedAre there any user-facing changes?
Yes.
Services using reqsign now send signing and credential-fetch HTTP requests through the accessor's HTTP client configuration, so injected clients are respected consistently. No public API changes.
AI Usage Statement
Implemented with Codex (GPT-5) in the local repository, with human review before PR submission.