Skip to content

HDDS-15345. Make GetBucketLocation return NotImplemented Response#10332

Merged
adoroszlai merged 2 commits into
apache:masterfrom
fmorg-git:HDDS-15345
May 25, 2026
Merged

HDDS-15345. Make GetBucketLocation return NotImplemented Response#10332
adoroszlai merged 2 commits into
apache:masterfrom
fmorg-git:HDDS-15345

Conversation

@fmorg-git
Copy link
Copy Markdown
Contributor

Please describe your PR in detail:

  • While doing dev validation for STS feature branch, I noticed that the S3 GetBucketLocation api is not implemented, even though it is documented as such. Worse, it incorrectly returns a ListBucketResult response. This ticket will update the documentation and also make invocations properly return a 501 NotImplemented error.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15345

How was this patch tested?

tested with Postman and aws s3 api cli

Copy link
Copy Markdown
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmorg-git for the patch.

| ✅ [CreateBucket](https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html) | Creates a new bucket. | **Non-compliant behavior:** The default bucket ACL may include extra group permissions instead of being strictly private. Bucket names must adhere to S3 naming conventions. |
| ✅ [HeadBucket](https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadBucket.html) | Checks for the existence of a bucket. | Returns a 200 status if the bucket exists. |
| ✅ [DeleteBucket](https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteBucket.html) | Deletes a bucket. | Bucket must be empty before deletion. |
| ✅ [GetBucketLocation](https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html) | Retrieves the location (region) of a bucket. | Typically returns a default region (e.g., `us-east-1`), which may differ from AWS if region-specific responses are expected. |
Copy link
Copy Markdown
Contributor

@smengcl smengcl May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created this PR for the doc site repo: apache/ozone-site#450

Copy link
Copy Markdown
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI

@adoroszlai adoroszlai merged commit e4db8a6 into apache:master May 25, 2026
91 of 93 checks passed
@adoroszlai
Copy link
Copy Markdown
Contributor

Thanks @fmorg-git for the patch, @smengcl for the review.

@fmorg-git
Copy link
Copy Markdown
Contributor Author

Thanks all for the review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants