Fix errors and grammar in BloomFilter.md and PageIndex.md#577
Open
iemejia wants to merge 1 commit into
Open
Conversation
BloomFilter.md: - Fix block_check pseudocode: setBit -> isSet (checking, not setting) - Fix struct name to match thrift (BloomFilterHeader) - Include missing bloom_filter_length field in ColumnMetaData snippet - Normalize "Bloom filter" casing (proper noun) throughout - "64 bits version" -> "the 64-bit version" - Normalize "bit set" -> "bitset" (consistent with thrift) - Add terminal periods in thrift-style doc comments PageIndex.md: - Fix "Blart Versenwald III" double-quote typo - Fix heading capitalization: "page index" -> "Page Index" - Fix article: "one data page per the retrieved column" -> "per retrieved column" - Add missing terminal period after parquet.thrift link
alamb
approved these changes
Jun 3, 2026
| for j in [0..31] { | ||
| if (masked.getWord(i).isSet(j)) { | ||
| if (not b.getWord(i).setBit(j)) { | ||
| if (not b.getWord(i).isSet(j)) { |
| **/ | ||
| struct BloomFilterPageHeader { | ||
| /** The size of bitset in bytes **/ | ||
| struct BloomFilterHeader { |
Contributor
There was a problem hiding this comment.
I verified this matches what is in
parquet-format/src/main/thrift/parquet.thrift
Line 798 in a7d9dd9
| ... | ||
| /** Byte offset from beginning of file to Bloom filter data. **/ | ||
| 14: optional i64 bloom_filter_offset; | ||
|
|
Contributor
There was a problem hiding this comment.
Verified it is in
parquet-format/src/main/thrift/parquet.thrift
Lines 934 to 940 in a7d9dd9
| struct BloomFilterPageHeader { | ||
| /** The size of bitset in bytes **/ | ||
| struct BloomFilterHeader { | ||
| /** The size of bitset in bytes. **/ |
Contributor
There was a problem hiding this comment.
Any chance you can update parquet.thrift to match these changes?
parquet-format/src/main/thrift/parquet.thrift
Lines 798 to 806 in a7d9dd9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix pseudocode bugs, missing fields, and grammar issues in the Bloom filter and Page index documentation.
Changes
BloomFilter.md
block_checkpseudocode:setBit->isSet(checking bits, not setting them)bloom_filter_lengthfield in ColumnMetaData snippetPageIndex.md
Validation
No semantic/behavioral changes to the format specification. All fixes are documentation-only.
Split from #572 for easier review.