RATIS-2521. LifeCycle.startAndTransition(..) may cause illegal transition: CLOSING -> EXCEPTION.#1452
Merged
szetszwo merged 1 commit intoapache:masterfrom May 8, 2026
Merged
Conversation
…tion: CLOSING -> EXCEPTION.
adoroszlai
approved these changes
May 8, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch.
Comment on lines
+121
to
+122
| Thread.sleep(100); | ||
| assertEquals(STARTING, simulatedServer.getLifeCycleState()); |
Contributor
There was a problem hiding this comment.
Would using JavaUtils.attemptUntilTrue be better than Thread.sleep?
Contributor
Author
There was a problem hiding this comment.
Since the test is very simple, it is reliable to just use Thread.sleep.
An embarrassing reason is that TestRaftAsyncWithNetty often fails. It is not easy to pass all the tests. We probably should disable TestRaftAsyncWithNetty until it is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RATIS-2521