Repository navigation
Make the scan exclusion and async MP-JWT tests independent of their environment - #3088
Merged
Merged
Conversation
…nvironment Check the excluded webapp jars directly instead of capturing a log record, and let the fake AsyncContext return null instead of throwing in getRequest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewLoaderLogicTest captured the INFO record of the scan exclusion report through a JUL handler, which only works if an earlier test configured OpenEJB logging, so it fails when run alone. It now asserts on DeploymentLoader.builtinExcludedWebappJars directly. MPJWTFilterExitWebAppTest's fake AsyncContext threw in getRequest/getResponse, which AsyncEvent reads on the Servlet 6.0 API used by tomee-10.x; it now returns null. Both are test-only changes, already applied on tomee-10.x.