[Docs] Update outdated references from recent refactors #18906
[Docs] Update outdated references from recent refactors #18906tlopex merged 1 commit intoapache:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request comprehensively updates various documentation files to synchronize them with recent significant refactors within the codebase. The changes ensure that instructions for building, linting, and understanding core architectural components like the FFI system are accurate and reflect the current state of the project, improving the experience for both new and existing contributors and users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request does a good job of updating outdated references in the documentation, including Python version requirements, build commands, and links to source files. The changes align well with recent refactorings in the codebase. I've found one minor issue where a reference to a removed type definition was not updated in the explanatory text, which could cause confusion for readers. Otherwise, the updates are accurate and improve the documentation's correctness.
I am having trouble creating individual review comments. Click here to see my feedback.
docs/arch/pass_infra.rst (165-167)
While you've correctly removed this typedef, a reference to PassContextThreadLocalStore remains on line 119. This reference is now dangling and should be updated to reflect the current thread-local storage implementation, for example by referring to PassContextThreadLocalEntry.
|
cc @tqchen |
docker/lint.sh/docker/bash.sh ci_linttopre-commit([LINT] Modernize lint to use pre-commit hooks #18807)make/make runtimewith CMake commands (root Makefile removed in [REFACTOR] Phase out root Makefile #18828)dmlc::ThreadLocalStorereference in pass_infra (dmlc phased out in [REFACTOR] Phase out dmlc dep #18779)packed_func.h→tvm/ffi/function.h)tvm.testing.ErrorTestexample in error_handling.rstapps/extensionlink in runtime.rst