Repository navigation
Conversation
The docs toolchain now runs in a job with a read-only token. The signed commit, the Pages deploy and the CloudFront invalidation run in separate jobs that do not install or build anything.
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/44062271701#summary-133966910179 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs workflow ran the whole docs toolchain (
pnpm install, the theme update, the Docusaurus build) in the same job that holds the service account token. Now the build job only gets a read-onlyGITHUB_TOKENand hands the changed files over as an artifact, and a separate job that runs no toolchain does the signed commit. The Pages deploy and CloudFront invalidation get their own job too.The workflow only runs from
master, so this can't be exercised before merge.actionlintis clean.