Skip to content

ci: split the docs workflows into build, commit and deploy jobs - #2462

Closed
B4nan wants to merge 1 commit into
v2from
ci/split-docs-jobs-v2
Closed

B4nan wants to merge 1 commit into
v2from
ci/split-docs-jobs-v2

Conversation

@B4nan

@B4nan B4nan commented Nov 17, 2026

Copy link
Copy Markdown
Member

Same change as #2461, for the v2 branch.

The docs workflows ran the whole docs toolchain (uv sync, pnpm install, the Docusaurus build) in the same job that holds the service account token. Now the build job only gets a read-only GITHUB_TOKEN and hands the changed files over as an artifact, and a separate job that runs no toolchain does the signed commit. The Pages deploy and CloudFront invalidation get their own job too.

Also drops the npx only-allow pnpm preinstall hook from the website, since packageManager already covers that.

The workflows only run from the release branches, so this can't be exercised before merge. actionlint is clean.

The docs toolchain now runs in a job with a read-only token. The signed commit, the Pages deploy and the CloudFront invalidation run in separate jobs that do not install or build anything.

Also drops the `npx only-allow pnpm` preinstall hook from the website.
@B4nan B4nan added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v2@efef3e9). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #2462   +/-   ##
=====================================
  Coverage      ?   95.11%           
=====================================
  Files         ?      195           
  Lines         ?    15113           
  Branches      ?        0           
=====================================
  Hits          ?    14374           
  Misses        ?      739           
  Partials      ?        0           
Flag Coverage Δ
integration 75.39% <ø> (?)
unit 88.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a dedicated PR for v2 or we shall rather rebase upon master once this #2461 is merged?

@B4nan

B4nan commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

right, let's just rebase, the other repos already have the next major in master, but here we don't need the other PR

@B4nan B4nan closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants