Repository navigation
fix(redis)!: Close the Redis client and open storages per backend #2463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mantisus
wants to merge
3
commits into
apify:v2
Choose a base branch
from
Mantisus:redis-backend-close
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 13 additions & 6 deletions
19
docs/03_concepts/code_examples/storage_backends/redis_storage_backend_basic_example.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,17 @@ | ||
| from crawlee.crawlers import ParselCrawler | ||
| from crawlee.storage_backends import RedisStorageBackend | ||
|
|
||
| # Create a new instance of storage backend using connection string. | ||
| # 'redis://localhost:6379' is the just placeholder, replace it with your actual | ||
| # connection string. | ||
| storage_backend = RedisStorageBackend(connection_string='redis://localhost:6379') | ||
|
|
||
| # And pass it to the crawler. | ||
| crawler = ParselCrawler(storage_backend=storage_backend) | ||
| async def main() -> None: | ||
| # Create a new instance of the storage backend using a connection string. | ||
| # 'redis://localhost:6379' is just a placeholder. Replace it with your actual | ||
| # connection string. | ||
| # Use the context manager to ensure that connections are properly cleaned up. | ||
| async with RedisStorageBackend( | ||
| connection_string='redis://localhost:6379' | ||
| ) as storage_backend: | ||
| # And pass it to the crawler. | ||
| crawler = ParselCrawler(storage_backend=storage_backend) | ||
|
|
||
| # Run the crawler inside the block, while the storage backend is open. | ||
| await crawler.run(['https://crawlee.dev']) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The
async withblock ends right after the crawler is created, so the backend is closed before anything runs. A user who addsawait crawler.run(...)after the block gets "The RedisStorageBackend is closed". Running the crawler inside the block (as the upgrading guide does) would show the right pattern. Same inredis_storage_backend_configuration_example.py.✍️ Drafted by Claude Code