Repository navigation
Conversation
vdusek
reviewed
Nov 18, 2026
| return | ||
|
|
||
| timeout_secs = timeout.total_seconds() if timeout else None | ||
| timeout_secs = timeout.total_seconds() if timeout is not None else None |
Collaborator
There was a problem hiding this comment.
Suggestion: Now that zero and None mean different things, the public docstrings should say it: None waits without a limit, zero cancels right away. Only the upgrading guide says it now. The docstrings are close_timeout and wait_for_all_listeners_to_complete(timeout=...) in events/_event_manager.py, and wait_for_all_requests_to_be_added_timeout in request_loaders/_request_manager.py and BasicCrawler.add_requests.
✍️ Drafted by Claude Code
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A zero
close_timeoutof an event manager, or a zerotimeoutpassed toEventManager.wait_for_all_listeners_to_complete(), now cancels the running event listeners right away. A zerowait_for_all_requests_to_be_added_timeoutinadd_requests()does the same for the requests still being added.A zero timeout used to wait without a limit. To wait without a limit, pass
None.Testing
✍️ Drafted by Claude Code