Skip to content

Fix connect -H keeping only the last repeated header - #491

Merged
jancurn merged 1 commit into
mainfrom
claude/quirky-babbage-serkkq
Nov 13, 2026
Merged

jancurn merged 1 commit into
mainfrom
claude/quirky-babbage-serkkq

Conversation

@jancurn

@jancurn jancurn commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

mcpc connect -H a -H b stored and sent only b: the -H option had no Commander collector, so each value overwrote the previous one. Putting Authorization first therefore dropped it and surfaced as a misleading "Authentication required" error.

  • -H/--header now accumulates every value into an array
  • The header-security e2e suite asserts all repeated headers are stored (it passed vacuously before; verified it fails without the fix)
  • CHANGELOG entry under Fixed

Fixes #490

🤖 Generated with Claude Code

https://claude.ai/code/session_015KycPr1CQ32KX6CsV7RUWQ

Commander keeps only the last value of an option without a collector, so
`connect -H a -H b` stored and sent just `b`. Accumulate every -H into an
array, and assert in the header-security e2e suite that all repeated
headers are stored.

Fixes #490

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015KycPr1CQ32KX6CsV7RUWQ
@jancurn jancurn changed the title Fix: Store all repeated --header options in connect command Fix connect -H keeping only the last repeated header Nov 13, 2026
@jancurn
jancurn merged commit 7aac80e into main Nov 13, 2026
7 checks passed
@jancurn
jancurn deleted the claude/quirky-babbage-serkkq branch November 13, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

connect -H keeps only the last header when repeated

2 participants