Repository navigation
feat: Add throttle_limits to count memory.high as a memory limit - #25
Merged
Merged
Conversation
Contributor
|
I am not sure about this. Can we make it configurable? This seems like an application decision whether they want to respect the soft limit |
Collaborator
Author
|
Great idea. I'll update it. |
Mantisus
marked this pull request as draft
November 10, 2026 12:18
memory.high as a memory limit under cgroup v2throttle_limits to count memory.high as a memory limit
Mantisus
marked this pull request as ready for review
November 10, 2026 14:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On cgroup v2 a level can limit memory with
memory.maxand withmemory.high. Onlymemory.maxwas read, so a limit set withmemory.highalone gave no budget.get_memory_budget(),snapshot()anddescribe()take a keywordthrottle_limits. Withthrottle_limits=True, each level's limit is the tighter ofmemory.maxandmemory.high.False.memory.highis then not read at all, and the behaviour stays as before.throttle_limits=True, amemory.highthat cannot be read is handled as an unreadablememory.maxis.Issues
memory.highas a memory limit on cgroup v2 #22Testing
memory.highbelow and abovememory.max, and unset;memory.soft_limit_in_bytes.throttle_limits=True: a systemd scope withMemoryHigh, and amemory.highset inside a Docker container.