Repository navigation
fix: return select query responses without SDK model parsing - #126
Merged
Merged
Conversation
🟢 Tier S · Ready to merge
Calls whose queries include
📂 Walkthrough · 2
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
selectquery makes Appwrite return only the chosen attributes for each item in a list. The Console SDK still validates that response against the full model, where every attribute is required, so a successful call raisesUnable to parse response into DeploymentList(Sentry MCP-12 and MCP-13, about 760 events, still firing on 1.0.3). The agent made a valid request and the server answered it, but the tool call reports a failure.When a tool call's
queriesinclude aselect,execute_registered_toolnow replaces the service instance's_parse_responsewith a passthrough, so the SDK returns the response dict as-is. The server already serialises models back to JSON for the client, so the agent gets the same data it asked for. Calls withoutselectare unchanged and still parse into typed models.This is deliberately limited to
select: that's the one case where partial responses are expected by design rather than a contract bug, so other parse failures keep surfacing in Sentry.Tests:
test_execute_registered_tool_returns_selected_attributes_untypedruns the realfunctions_list_deploymentstool against a partial response. Withselectit returns the raw payload, and withoutselectit still fails. It errors without the fix.Verification:
ruff check,black --checkandpyrightare clean, andpython -m unittest discover -s tests/unitpasses.