Skip to content

fix: cap encoding_rs and hyper-util to keep building on Rust 1.83 - #30

Merged
ChiragAgg5k merged 1 commit into
mainfrom
fix/hyper-util-msrv
Oct 6, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
fix/hyper-util-msrv

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

The 0.15.0 publish failed at cargo test: the workflow runs Rust 1.83.0 (the crate's rust-version), and the latest hyper-util (0.1.21, needs Rust 1.85) and encoding_rs (0.8.40+, needs Rust 1.88) cannot even be parsed by Cargo 1.83.

This adds the same two caps the generator template already carries (appwrite/sdk-generator 9cd77bb2c and 0ed7664ab), so the dependency block matches the template exactly:

encoding_rs = ">=0.8.35, <0.8.40"
hyper-util = ">=0.1, <0.1.21"

cargo +1.83.0 test --all-features passes locally (751 tests). 0.15.0 never reached crates.io, so after this merges the 0.15.0 tag and release are re-pointed to the fixed commit and published.

encoding_rs 0.8.40+ and hyper-util 0.1.21 need newer Rust than the crate's rust-version (1.83) and the publish workflow's toolchain, so the 0.15.0 publish failed at cargo test. Same caps as the generator template (appwrite/sdk-generator 9cd77bb2c, 0ed7664ab).
@hansi-codes

hansi-codes Bot commented Oct 6, 2026

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

No concrete defects found in the dependency caps or their interaction with the existing manifest and publish workflow.

Adds upper bounds for encoding_rs and hyper-util to exclude releases that require newer Rust versions. The change keeps the dependency constraints aligned with the crate’s declared Rust 1.83 minimum and the existing publish workflow.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 1
File Change
Cargo.toml Adds compatible version ranges for encoding_rs and hyper-util.

Reviewed 29051f2 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit 6308085 into main Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant