Repository navigation
fix: cap encoding_rs and hyper-util to keep building on Rust 1.83 - #30
Merged
Merged
Conversation
encoding_rs 0.8.40+ and hyper-util 0.1.21 need newer Rust than the crate's rust-version (1.83) and the publish workflow's toolchain, so the 0.15.0 publish failed at cargo test. Same caps as the generator template (appwrite/sdk-generator 9cd77bb2c, 0ed7664ab).
🟢 Tier S · Ready to merge
Adds upper bounds for encoding_rs and hyper-util to exclude releases that require newer Rust versions. The change keeps the dependency constraints aligned with the crate’s declared Rust 1.83 minimum and the existing publish workflow.
📂 Walkthrough · 1
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.15.0 publish failed at
cargo test: the workflow runs Rust 1.83.0 (the crate'srust-version), and the latesthyper-util(0.1.21, needs Rust 1.85) andencoding_rs(0.8.40+, needs Rust 1.88) cannot even be parsed by Cargo 1.83.This adds the same two caps the generator template already carries (appwrite/sdk-generator 9cd77bb2c and 0ed7664ab), so the dependency block matches the template exactly:
cargo +1.83.0 test --all-featurespasses locally (751 tests). 0.15.0 never reached crates.io, so after this merges the 0.15.0 tag and release are re-pointed to the fixed commit and published.