Skip to content

feat: Web SDK update for version 29.0.0 - #187

Closed
ChiragAgg5k wants to merge 2 commits into
mainfrom
dev
Closed

ChiragAgg5k wants to merge 2 commits into
mainfrom
dev

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the Web SDK for version 29.0.0.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

馃煝 Tier S 路 Ready to merge

This release updates the Web SDK to version 29.0.0 and targets Appwrite 2.4, adding passkey APIs and response-model defaults alongside OAuth, team, and analytics updates. It also adds passkey examples and updates the SDK and server-version documentation.

11 of 37 changed files were too large to include in full.

Verdict New comments Fixed Still open
馃挰 Commented 0 0 0

Note

Part of the diff was too large to review, so Hansi did not approve.

馃搨 Walkthrough 路 7
File Change
CHANGELOG.md, README.md, package.json, package-lock.json Publish version 29.0.0, document Appwrite 2.4 compatibility, and summarize the release APIs.
src/client.ts Add a response helper to populate missing model fields and update SDK response headers.
src/models.ts, src/services/account.ts Add passkey models and account endpoints, and apply defaults to account responses.
src/services/apps.ts, src/services/databases.ts, src/services/documents-db.ts, src/services/functions.ts, src/services/locale.ts, src/services/messaging.ts, src/services/oauth-2.ts, src/services/organization.ts, src/services/presences.ts, src/services/storage.ts, src/services/tables-db.ts, src/services/teams.ts, src/services/vectors-db.ts Update generated service response handling and API contracts for Appwrite 2.4.
src/services/analytics-tracking.ts, src/services/analytics.ts Include viewport width in tracked events and update the Analytics property-ID description.
docs/examples/account/*.md Add examples for the passkey account endpoints.
docs/examples/oauth2/*.md, docs/examples/teams/create-membership.md Update OAuth resource examples and show the optional membership ID.
馃攪 Filtered out 路 1

Findings Hansi considered but did not post.

Finding Why
Default passkey options to an object shape Verifier: The fallback does not replace actual WebAuthn options: fillDefaults spreads the response over the defaults (src/client.ts:83), so a returned publicKey is preserved. The finding depends on a successful challenge response omitting its required options, for which no reachable case is shown. Moreover, changing [] to {} would still fail both WebAuthn parsers because required fields such as challenge (and registration fields) are missing; the array shape is not the cause of that failure. API errors already reject before defaults are applied.

Reviewed 4601664 路 Details 路 Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煝 Tier S 路 Looks good to merge. Summary

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Superseded: replaced by a passkeys-only minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant