Repository navigation
feat: SDK update for version 28.2.0 - #188
Conversation
🔵 Tier A · Mergeable after minor fixes
Adds passkey registration, management, and sign-in methods to the Web SDK, along with the corresponding models and usage examples. Updates the package and SDK version to 28.2.0 while retaining the existing response-format header.
Fix with agent prompt### Issue 1
docs/examples/account/update-passkey-token.md:12
**Show an authenticator credential in the example**
As written, this sends an empty object as the authenticator assertion, which the server rejects even after the challenge ID is filled in. Could the example show the JSON from `navigator.credentials.get()` (and the corresponding `navigator.credentials.create()` result in `update-passkey-verification.md`) so users can complete these calls?
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 15
Reviewed |
|
|
||
| const result = await account.updatePasskeyToken({ | ||
| challengeId: '<CHALLENGE_ID>', | ||
| credential: {}, |
There was a problem hiding this comment.
Show an authenticator credential in the example
As written, this sends an empty object as the authenticator assertion, which the server rejects even after the challenge ID is filled in. Could the example show the JSON from navigator.credentials.get() (and the corresponding navigator.credentials.create() result in update-passkey-verification.md) so users can complete these calls?
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/account/update-passkey-token.md
Line: 12
Comment:
**Show an authenticator credential in the example**
As written, this sends an empty object as the authenticator assertion, which the server rejects even after the challenge ID is filled in. Could the example show the JSON from `navigator.credentials.get()` (and the corresponding `navigator.credentials.create()` result in `update-passkey-verification.md`) so users can complete these calls?
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · documentation · Reply if this doesn't apply.
This PR contains updates to the SDK for version 28.2.0.
What's Changed
accountpasskey methodslistPasskeys,createPasskey,getPasskey,updatePasskey,deletePasskeyandupdatePasskeyVerificationaccount.createPasskeyTokenandaccount.updatePasskeyTokenfor passkey sign-inPasskey,PasskeyList,PasskeyChallengeandTokenSecretmodelsPasskeys only, patched onto
28.1.0: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including itsX-Appwrite-Response-Format.