Skip to content

feat: SDK update for version 28.2.0 - #188

Merged
ChiragAgg5k merged 1 commit into
28.xfrom
release-28.2.0
Oct 12, 2026
Merged

ChiragAgg5k merged 1 commit into
28.xfrom
release-28.2.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 28.2.0.

What's Changed

  • Added: account passkey methods listPasskeys, createPasskey, getPasskey, updatePasskey, deletePasskey and updatePasskeyVerification
  • Added: account.createPasskeyToken and account.updatePasskeyToken for passkey sign-in
  • Added: Passkey, PasskeyList, PasskeyChallenge and TokenSecret models

Passkeys only, patched onto 28.1.0: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including its X-Appwrite-Response-Format.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The passkey completion examples use empty credentials and cannot succeed as written, which is a minor documentation issue.

Adds passkey registration, management, and sign-in methods to the Web SDK, along with the corresponding models and usage examples. Updates the package and SDK version to 28.2.0 while retaining the existing response-format header.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Show an authenticator credential in the example docs/examples/account/update-passkey-token.md:12
Fix with agent prompt
### Issue 1
docs/examples/account/update-passkey-token.md:12
**Show an authenticator credential in the example**

As written, this sends an empty object as the authenticator assertion, which the server rejects even after the challenge ID is filled in. Could the example show the JSON from `navigator.credentials.get()` (and the corresponding `navigator.credentials.create()` result in `update-passkey-verification.md`) so users can complete these calls?

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 15
File Change
CHANGELOG.md Documents the 28.2.0 passkey additions.
README.md Updates the CDN example to version 28.2.0.
docs/examples/account/create-passkey-token.md Adds an example for starting passkey sign-in.
docs/examples/account/create-passkey.md Adds an example for starting passkey registration.
docs/examples/account/delete-passkey.md Adds an example for deleting a passkey.
docs/examples/account/get-passkey.md Adds an example for retrieving a passkey.
docs/examples/account/list-passkeys.md Adds an example for listing passkeys.
docs/examples/account/update-passkey-token.md Adds an example for completing passkey sign-in.
docs/examples/account/update-passkey-verification.md Adds an example for completing passkey registration.
docs/examples/account/update-passkey.md Adds an example for renaming a passkey.
package.json Bumps the package version to 28.2.0.
package-lock.json Synchronizes the lockfile version to 28.2.0.
src/client.ts Updates the SDK version header to 28.2.0 and leaves the response-format header unchanged.
src/models.ts Adds the passkey and token-secret models.
src/services/account.ts Adds account methods for passkey management, registration, and sign-in.

Reviewed ca71e8e · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary


const result = await account.updatePasskeyToken({
challengeId: '<CHALLENGE_ID>',
credential: {},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show an authenticator credential in the example

As written, this sends an empty object as the authenticator assertion, which the server rejects even after the challenge ID is filled in. Could the example show the JSON from navigator.credentials.get() (and the corresponding navigator.credentials.create() result in update-passkey-verification.md) so users can complete these calls?

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/account/update-passkey-token.md
Line: 12

Comment:
**Show an authenticator credential in the example**

As written, this sends an empty object as the authenticator assertion, which the server rejects even after the challenge ID is filled in. Could the example show the JSON from `navigator.credentials.get()` (and the corresponding `navigator.credentials.create()` result in `update-passkey-verification.md`) so users can complete these calls?

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit 03ac063 into 28.x Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant