Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"zone.js": "~0.16.3"
},
"devDependencies": {
"@angular/build": "^21.2.29",
"@angular/cli": "^21.2.29",
"@angular/build": "^22.0.0",
"@angular/cli": "^22.0.0",
Comment on lines +30 to +31

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the lockfile with these dependency versions

package-lock.json still records @angular/build and @angular/cli as ^21.2.29, so the CI workflow's npm ci step fails because the lockfile does not match package.json (the reported build failure occurs at this install step). Please regenerate and commit the lockfile alongside this change.

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 30-31

Comment:
**Update the lockfile with these dependency versions**

`package-lock.json` still records `@angular/build` and `@angular/cli` as `^21.2.29`, so the CI workflow's `npm ci` step fails because the lockfile does not match `package.json` (the reported build failure occurs at this install step). Please regenerate and commit the lockfile alongside this change.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟠 Major · bug · Reply if this doesn't apply.

Comment on lines +30 to +31

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the Angular toolchain on a compatible major version

@angular/build@22 requires Angular 22 peers and TypeScript >=6.0 <6.1, but this manifest still has Angular and @angular/compiler-cli 21 with TypeScript 5.9. Even after refreshing the lockfile, npm cannot resolve this dependency set and the build toolchain is incompatible; align the framework/compiler/TypeScript versions or keep @angular/build on 21.

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 30-31

Comment:
**Keep the Angular toolchain on a compatible major version**

`@angular/build@22` requires Angular 22 peers and TypeScript `>=6.0 <6.1`, but this manifest still has Angular and `@angular/compiler-cli` 21 with TypeScript 5.9. Even after refreshing the lockfile, npm cannot resolve this dependency set and the build toolchain is incompatible; align the framework/compiler/TypeScript versions or keep `@angular/build` on 21.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟠 Major · bug · Reply if this doesn't apply.

"@angular/compiler-cli": "^21.2.25",
"@types/jasmine": "~5.1.0",
"jasmine-core": "~5.5.0",
Expand Down
Loading