Open
Conversation
Co-Authored-By: Claude Opus 4.6
Add embedded pie chart web component, templates, static assets, and pie_chart_no_cache setting. Store raw JSON on graph for pie chart data access.
Co-Authored-By: Claude Opus 4.6
The pie chart was the only visualization reading graph._raw_JSON directly, bypassing config filters like excludeFinalWinnerAndEliminatedCandidate. New converter in visualizer/pie/graphToRCtab.py builds RCTab-compatible JSON from the same processed Graph that bar chart and sankey use. Co-Authored-By: Claude Opus 4.6
- Pass textForWinner and excludeFinalWinnerAndEliminatedCandidate - Set currentRound to numRounds so pie loads on last round - Rebuilt standalone component with new props Co-Authored-By: Claude Opus 4.6
Following the hideSankey/hideTabular pattern: model field, config JS variable, settings checkbox, and tab hiding in hideTabsBasedOnConfig(). Co-Authored-By: Claude Opus 4.6
Covers structure validation, tally correctness, eliminations, multi-winner surplus, inactive ballots, no-threshold elections, excludeFinalWinner flag, and the _stringify helper. Co-Authored-By: Claude Opus 4.6
Co-Authored-By: Claude Opus 4.6
Use a coprime stride near N/2 to reorder the color palette so that visually similar colors are spread apart around the pie chart. Co-Authored-By: Claude Opus 4.6
Replace color scramble with tally interleaving: alternate largest and smallest candidates so small slices always have a large neighbor, reducing label overlap. Inactive Ballots always last. Fix color generation to use actual tally entry count instead of config.numCandidates, which excluded Inactive Ballots and caused color wrapping on large elections. Co-Authored-By: Claude Opus 4.6
Per-round reordering broke D3 pie animation because candidate positions shifted between rounds. Now the interleave order is stable across all rounds, just dropping eliminated candidates. Co-Authored-By: Claude Opus 4.6
Tests pie vistype rendering, embedly redirect, hidePie config toggle, and cloudflare cache purge including pie URLs. Tests graphToRCtab with candidate names containing HTML, quotes, and other special characters. Co-Authored-By: Claude Opus 4.6
Set firstRoundDeterminesPercentages=false so percentages use active votes per round as denominator. Inactive Ballots shows count only. Animation button cycles Eliminate/Transfer/Consolidate labels. Co-Authored-By: Claude Opus 4.6
…hart Tooltip now positions near mouse cursor with viewport clamping. Pie chart centered (removed stale margin-right). Bubble visualization references removed. Co-Authored-By: Claude Opus 4.6
Set aspect-ratio and max-width on pie-body container so the browser allocates space before the custom element renders. Reduces Cumulative Layout Shift from 0.753 to 0.014. Co-Authored-By: Claude Opus 4.6
Co-Authored-By: Claude Opus 4.6
Co-Authored-By: Claude Opus 4.6
Co-Authored-By: Claude Opus 4.6
- Make pie_chart_no_cache conditional on DEBUG - Remove TODO comment from pie.css - Renumber hidePie migration to 0034 (avoids conflict with caching PR) - Move _stringify to common.stringify (public API) - Improve testGraphToRCtab docstring explaining its purpose - Remove scripts/reset-db.sh from .gitignore - Add pie chart round-change Selenium test Co-Authored-By: Claude Opus 4.6
artoonie
force-pushed
the
pie-template-clean
branch
from
25c9746 to
49e52dd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # Wait for the pie chart to render | ||
| self._ensure_eventually_asserts( | ||
| lambda: self.assertTrue(len(self._get_pie_svg_text()) > 0)) |
Check notice
Code scanning / CodeQL
Imprecise assert Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 12 hours ago
In general, to fix this type of issue you should replace generic boolean assertions like assertTrue(a > b) with the corresponding specific assertion, such as assertGreater(a, b), so that failing tests report the compared values. Alternatively, you can keep assertTrue but provide a descriptive message.
For this specific case in visualizer/tests/testLiveBrowserHeadless.py, we want to preserve the existing behavior—assert that the SVG text is non-empty—while improving the message. The best direct change is to use assertGreater on the length of the SVG text compared to zero. We should keep the lambda structure expected by _ensure_eventually_asserts, only changing the assertion call inside the lambda. Concretely, on line 732, replace self.assertTrue(len(self._get_pie_svg_text()) > 0) with self.assertGreater(len(self._get_pie_svg_text()), 0). No new imports or helper methods are required, since assertGreater is provided by unittest.TestCase, which this class already inherits from.
Suggested changeset
1
visualizer/tests/testLiveBrowserHeadless.py
| @@ -729,7 +729,7 @@ | ||
|
|
||
| # Wait for the pie chart to render | ||
| self._ensure_eventually_asserts( | ||
| lambda: self.assertTrue(len(self._get_pie_svg_text()) > 0)) | ||
| lambda: self.assertGreater(len(self._get_pie_svg_text()), 0)) | ||
|
|
||
| # Change to round 1 via the pie's round player select. | ||
| # Round 1 should have all candidates including Banana, |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.