Repository navigation
residency owners: the recording root exports affine_mm, so test-metal-residency-owners-host compiles again - #2331
Conversation
|
Thanks @jishnuvenugopal. Confirmed on an Apple M3 Ultra: It's in the landing queue, with a CHANGELOG line that thanks you. Once it lands, the step can come off #2095's exclusion list, as you say. |
|
/atc exchange 3e17c53089ba0120568ae4318704fa5ade6905ef70a6c936104c9eb7aaff60c8 |
238ace8 to
6037571
Compare
…-residency-owners-host compiles again
6037571 to
dc0cfc1
Compare
|
Thank you @jishnuvenugopal. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
|
Thanks @jishnuvenugopal! This is in TensorFold 1.2.4, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.4 |
Thank you, @ashhart, for settling how #2031 splits, and @garvrao80 for carrying the CI side in #2095, which is what keeps this step on a reviewed list instead of forgotten. Thanks too, @BobClawblaw, for the routed-expert path in 10eb897: it's why the recording root has one more name to export.
What this changes
zig/src/families/qwen27/moe_gpu.zig:6readscore.affine_mm. Intest-metal-residency-owners-host,coreis the recording rootzig/residency_owner_tests.zig, whichzig/build/residency_host.zighands to the Qwen27 engine modules. That root exportsaffine4andaffine4_lanebut notaffine_mm, so the step stops withroot source file struct 'residency_owner_tests' has no member named 'affine_mm'. One line adds the export, in the same form as the lines beside it. Only a test root changes.test-metal-residency-owners-hostcan come off ci: collect native Linux host checks and guard exclusions #2095's exclusion list. This does not put named steps on CI.mainat 3e37f94, one commit, 238ace8. Through ac470c0,zig/residency_owner_tests.zighas not changed on main, andzig/src/core/affine_mm.zighas had comment-only changes. On 34d42fc the step still fails without this commit and passes 68/68 with it.atc overlap --json: ATC 0.8.1 found no overlaps, but the run reportscomplete: false(pullFilesUnavailable,timeLimit), so it is not a full result on its own. The same check by hand: the changed-file lists of all 187 open pull requests, and none toucheszig/residency_owner_tests.zig.atc check 2031saystakenOutsidebecause ci: collect native Linux host checks and guard exclusions #2095 references the issue; the split between ci: collect native Linux host checks and guard exclusions #2095's CI work and these fixture repairs was agreed on CI never reaches 246 of the 393 named test steps, and nine of them fail on main #2031.Verified outcome
Checks on this head
python3 tools/zig/lean_check.py, thentools/zig/lean_new.py: 425 problems on 3e37f94 and 425 on this commit, 0 new.test-metal-residency-owners-hostaffine_mmtest-flashnext-vision-memory-hosttest-flashnext-cleanup-hosttest-qwen-dense-route-hostzig build test, empty cache on each sidetest-goldentest-kernel-contractfuzz-cortheontest-server-securityzig fmt --check build.zig zigandgit diff --checkagainst 3e37f94 are clean on this commit.zig build testis the same on main and on this commit:exl3_load's "a scan that fails an allocation frees every group prefix it held", which fails without output. This change does not touch it, and I have not looked into its cause.zig build test, 62 stop becausexcruncannot findmetal, and the other is that test. The names match on both sides.mainunseen, so this green run cannot show this fix. The local mirror is the table above.zig build,nativeanddev-tools(no Xcode here, and this file is in none of them), Metal and CUDA devices, Linux hosts, and Windows hosts.Receipt
n/a: this changes a test root that no shipped binary builds, so it cannot reach inference.
Checklist