Repository navigation
Evidence index: read native capabilities and reject invalid input - #2708
Merged
Merged
Conversation
Owner
Author
|
/atc exchange a86b77f5f3dbf11ee5e6052a6e73bc0d89b4011d707a9bd1b2964e6e711e4e68 |
ashhart
force-pushed
the
codex/evidence-native-schema
branch
from
November 9, 2026 22:19
24429b4 to
a1af283
Compare
ashhart
marked this pull request as ready for review
November 9, 2026 22:53
ashhart
force-pushed
the
codex/evidence-native-schema
branch
from
November 9, 2026 23:40
a1af283 to
3c5d55a
Compare
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A saved native
capabilities --jsonfile currently crashes the evidence index because native schema 1 maps families to format arrays. The index now reads those advertised facts at unknown measurement grade and rejects invalid supplied input with a bounded error instead of an empty success or traceback.79d3dc661fa8e9e01b5674c83996f0db9d3f06cd; two commits53b8f0a8d3429849e982eaa168474e93a5266963anda1af2836fb5df8b422430d8ca64761635221286a.atc overlap --json: 9 Nov 2026, base79d3dc6. Current working-tree overlaps with ci: collect native Linux host checks and guard exclusions #2095 and qwen35: dense BF16 loading and native prompt logprobs #2020 merge cleanly. The ordinary account portfolio remains incomplete and reports unrelated existing PR conflicts. The ticket publication guard separately checks the actual worktree against all peers and returns complete/ready under ATC 0.9.3. No overlap was waived.The captured native fixture produces 15 family-format facts, one backend and one chip. Root backends do not create inferred family/backend pairs. All advertised facts retain unknown grade and no measured commit or result. Legacy family lists remain supported. Supplied input is bounded by file, collection, fact and name limits; errors do not echo payloads or machine paths. An absent source and an available empty source remain distinct. Existing Linux/Windows host CI now explicitly runs the evidence-index tests.
Checks on this head
a1af2836fb5df8b422430d8ca64761635221286a, treea1c058bf31e22ef2d077974cf5a3e0238ab21801.python3 tools/zig/lean_check.py, on the base and on this head: 386 inherited problems in 6144 files on both trees, zero new findings. Both full checker exits are 1 because the inherited findings remain.python3 -m unittest discover -s tools/tests -p 'test_evidence*.py' -v: 32 passed on this head, zero failed/skipped.python3 -m unittest discover -s tools/tests -p 'test_bench*.py' -v: 148 passed on the rebased current source, zero failed/skipped.python3 tools/pr_check.py --base origin/main: zero errors/warnings.git diff --checkpassed. After the queue advanced main, the PR was rebased cleanly; all five feature files and the native producer contract remain identical to the reviewed source. The composition peer found no new asks. The public shallow test snapshot's base commit and entire tree match the selected source exactly; the five candidate file hashes match this head.The final 12-case regression suite was actually run against unchanged main before the fix. It fails on the captured native object, invalid-input/CLI behavior and input limits; legacy compatibility is a passing control. The candidate also had two JSON-number edge failures before bounded error handling. Fresh parallel source review then found valid native unknown-chip and XPU display-chip values rejected by the token validator. The final 14-case suite actually fails on
76fc751with three reader errors and three CLI failures. The revised reader omits null chips and accepts bounded chip display labels while keeping other names strict. All 32 evidence tests pass on this head. Both source peers rechecked the exact revision and report no remaining findings; these reports do not represent independent GitHub-account approval. No tolerances or engine settings changed.Receipt
n/a. This read-only evidence tool cannot reach inference.
--capabilitiesargument is unchanged.tools/bench_concurrent.py --alone --serialortoken_shaagainst"draft": false: n/a; inference is unreachable.tools/bench_openai.py: n/a; no decode changes.Checklist