Repository navigation
test: exercise pool spills in sessions write readback - #2731
Conversation
|
GREEN at 8cc4b72 — opencode-go/glm-5.3-flash as routed by Main (model id unverifiable); implementer model unverified. Red-first reproduced with Zig 0.17.0 at seed 0xece1bd70: base 21ea8de runs 2 pass / 1 fail (the nonzero-spill assertion — the 65,536-token pool never spilled), the head runs 3 pass / 0 fail. The one-line pool sizing to one slot's capacity is exactly what forces the mixed workload through spill admission in both policy modes while keeping the counter/peak comparison against the accounting run. CI 8x SUCCESS here. |
ashhart
left a comment
There was a problem hiding this comment.
Thanks. Holding the pool to one slot's capacity makes the mixed load spill, which the test meant to cover. Landing after the 1.2.6 cut.
8cc4b72 to
0b14945
Compare
|
Thank you @garvrao80. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
|
Thanks @garvrao80! This is in TensorFold 1.2.7, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.7
|
What this changes
The Linux sessions write/readback test requires a pool spill, but its 65,536-token pool had enough room for the seeded workload. The test now sizes the pool to one 32,768-token slot so the same workload exercises spill admission in both policy modes. The test still compares every real-file counter and peak disk use with the accounting run.
mainat21ea8dee4b05e952edf96f9aa40eab2944c9c1b2.atc overlap --jsonwas partial (pullFilesUnavailable,timeLimit) against that base on 2026-11-10 07:43:25 UTC. A direct GitHub changed-file audit of 197 open PRs found zero touchingzig/sessions_writes_test.zig, including renames.Checks on this head
8cc4b72c0090808ec346f770153184c97a145753.python tools/zig/lean_check.pyreported 386 findings on base and 386 on head.python tools/zig/lean_new.pyreported zero new findings.zig build -Dfixed-cpu test-sessions-writes-host -j2 --test-timeout 5m --seed=0xece1bd70 --summary allpassed 3/3 on Linux x86-64 with Zig 0.17.0, zero failures or skips. On base, the target had two passes and one failure. The diagnostic read 572,493,824 bytes back with matching counters and peak, then failed the nonzero spill assertion. On head the seeded workload produced 44 spills in each policy mode, and the covered mode also produced 61 deltas.zig fmt --check build.zig zigandgit diff --check origin/main...HEADpassed.zig build testandzig build test-goldenin the Linux no-GPU job. Both scheduled host-nightly jobs skipped on the PR event. The targeted Linux run above covers this fixture. The Linux nightly failure on main is the baseline.Receipt
Checklist