Repository navigation
core: Admit and Ledger move to engine_admission.zig, unchanged - #2896
Conversation
|
Thanks @kotevcode, this is the behaviour-free extraction we agreed on #2741: both types move byte for byte and keep their names under
|
bf58576 to
6cb4dbc
Compare
6cb4dbc to
15a9a32
Compare
|
@kotevcode, our landing train couldn't finish this one's rebase (a tooling problem on our side, now fixed), so we rebased it onto today's main and force-pushed (
|
15a9a32 to
6bb6302
Compare
|
Thank you @kotevcode. This is merged into main with your commits under your own name, so you're listed as a TensorFold contributor. It ships in the next release, credited to you in the changelog and the release notes. |
|
Thanks @kotevcode! This is in TensorFold 1.2.8, out now: https://github.com/ashhart/TensorFold/releases/tag/v1.2.8
|
What this changes
AdmitandLedgermove unchanged fromzig/src/core/engine_api.zigto a newzig/src/core/engine_admission.zig, andengine_apire-exports them under the same names, so no caller changes.engine_api.ziggoes from 600 to 593 lines, which leaves room for the execution witness'sInfohook. Behaviour is unchanged.atc overlap --json: run on this head against main;complete: false(otherPullRequestsLimit,pullFilesUnavailable,timeLimit). 7 pull requests report a textual conflict: dsv41 metal: image prompts #1722, dsv41 metal: the vision tower's kernels under the kernel contract #1721, dsv41 metal: the lane target, the prompt cache and the native server over Metal #1720, Vulkan: qmm_q4_vec4 reads the 4-bit projection 16 bytes at a time, 34.8% to 43.0% less run time on an M1 with the same logits (stacked on #1544) #1990, Implement GLP control vectors with a fused Metal kernel for Qwen3.8-27B #1835, app: control vector picker and strength in Engine advanced #1951 and GLM-5.3-Flash on CUDA keeps conversation states on disk, every rank's part (--learn-conversations) #1411. Each has one conflicting file. Six share onlyCHANGELOG.md; Implement GLP control vectors with a fused Metal kernel for Qwen3.8-27B #1835 also changesengine_api.zig, which merges cleanly, so its conflict isCHANGELOG.mdas well. Native Vulkan backend for Qwen3.5-2B (opt-in): engine and kernel-contract registration (stacked on #1526) #1544 is clean; the rest reportunknown.Checks on this head
python3 tools/zig/lean_check.py, on the base and on this head: 345 and 345, 0 new, after rebasing onto main eab305d (onlyCHANGELOG.mdconflicted).python3 tools/pr_check.py --base upstream/main --pr 2896: 0 errors, 0 warnings.zig build test-cuda-host(everyAdmitandLedgercaller): 379 of 379 steps succeeded, 0 failed.zig build test-server-cpu: all steps succeeded, 0 failed.zig fmt --check build.zig zigandgit diff --checkpass.Receipt
n/a: two type declarations move between files with identical fields and names, so nothing that reaches inference changes.
Checklist
The inference checklist is skipped because the Receipt is n/a.