Repository navigation
spark25 cuda: gate and up load as one stacked weight, and every CUDA chip decodes them in one launch - #3130
Open
ashhart wants to merge 2 commits into
Open
spark25 cuda: gate and up load as one stacked weight, and every CUDA chip decodes them in one launch#3130ashhart wants to merge 2 commits into
ashhart wants to merge 2 commits into
Conversation
…chip decodes them in one launch
…he draft precision test keeps its meaning
ashhart
force-pushed
the
lead/spark25-gate-up-stack
branch
from
November 14, 2026 03:51
84bab90 to
a2256df
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spark 2.5 on CUDA loaded gate and up as two weights and decoded them with two launches. They now load as one stacked weight and every CUDA chip decodes both in one launch. The bits stay the same: both members keep n=10240, so split-K stays 2; codes are addressed independently of
npad, and scales and biases usenpadas their stride; the seam is 128-aligned, so no tile crosses into the other member. On GB10 the same grouped kernels run. On other chips the segmented kernel replaces the split kernel at 16 rows or fewer, with the samegemv_split<64,64,4>body (split-K 2) and its own work and ticket areas; at 17-32 rows each member keeps its own launch. Only 4-bit checkpoints take this path.Tests:
test-spark25-host13,test-cuda-family-groups-host5 andtest-qwen35-verify-host8 pass; the new test records main's per-member launches and fails on main ("expected 1, found 0").compile-cuda-testspasses for aarch64 and x86_64 Linux.Device check pending (needs a Spark 2.5 MLX 4-bit checkpoint): on a GB10 and a non-GB10 sm_120 card, a served A/B against main with token hashes equal at T=0 and sampled with the same seed, over 1, 2, 8 and 16-row decode, 17-32-row verify windows on sm_120, the prompt, and solo versus concurrent streams; decode tok/s reported.