Repository navigation
Conversation
T0's group backend could not abort GLM's communicator before the RoCE group was installed, because it only borrowed it. GLM now hands the backend the group that owns the communicator from Engine.init, so an abort always reaches it once, and the start-up unwind uses the group's guarded destroy, which skips the destroy after an abort.
A failed spawn returned while the ranks already started still wrote to the test's frame, the same pattern #2700 fixed in host.runWith. Both tests now join the ranks they started on every return; in the gather test that also covers rank 0's own steps between the spawns and the join. Every wait in Bootstrap has a deadline, so the join is bounded.
Each app run uploads its ~230 MB AppImage, and with GitHub's default 90-day retention 2,069 copies (475 GB) had piled up in Actions storage by 12 Nov, enough to hit the account's Actions limit. The build is smoke-tested in the job itself; the upload is only for a quick download, which 3 days covers.
Owner
Author
|
Stopped: main is frozen for the 1.2.8 release at f8dacd7. These PRs land first after it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI for a landing train: #2963 #2095 #2966 stacked on main in that order. Nothing merges from this PR: each PR above lands on its own once this tip is green, and this PR is then closed.