Repository navigation
Replay suite for known subjects, and the gaps it found - #150
Merged
Merged
Conversation
_test_replay.mjs (in npm test) runs invented people, hard names on purpose, through five request shapes and checks: nothing leaks once redacted, ordinary lowercase use of a name's words is not refused, and replies round-trip real values to allowed tools only. Fixed what it found: names right after a JSON escape, one-word names in capitals, username-style joins matched inside other words, and initial joins read across words at egress.
sprayberry-redline
approved these changes
Oct 14, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. The replay suite exercises redaction, egress checking, and restoration across the supported request shapes, while the subject matcher changes cover escaped JSON boundaries, uppercase single-token names, and bounded handle forms. The focused regressions cover the newly fixed matching cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A replay suite for known subjects, and the four gaps it found on its first runs.
The suite:
_test_replay.mjs, innpm testCORDON_FUZZ_RUNSdeepens them; they pass at 1,000.What it found (fixed here)
\nGrant, and thenglued to the name, which defeated the word boundary.subjectSpansnow reads\n,\",\\and the other JSON escapes as separators of the same length, so offsets still point into the original text.Tests
_test_subject.mjs: capitals; JSON escapes; "the stone might" not read; "stonem77" still read; "advancement" untouched.