account dropdowns in QB settings

[SandipBajracharya]

No description provided.

[linear-code]

OUT-3275

[greptile-apps]

Greptile Summary

This PR adds an "Other Settings" accordion panel in the QuickBooks settings page, backed by a new GET /api/quickbooks/accounts and PATCH /api/quickbooks/accounts endpoint. The GET endpoint lists income, expense, and bank accounts from QBO grouped by type; the PATCH validates each provided ref's AccountType against QBO before persisting it to qb_portal_connections.

• API layer: AccountService fetches three parallel QBO queries and strips internal fields before returning. TokenService.updateAccountRefs validates each ref type against QBO's enum and scopes the UPDATE to the authenticated workspace. The controller uses SafePortalConnectionSchema.pick() to ensure token/secret columns are never returned in the response.
• UI layer: useOtherSettings skips the fetch when QB is disconnected or sync is off, seeds dropdown state from the SWR response, and sends only changed fields on PATCH. OtherSettings renders three custom AccountSelect dropdowns with ARIA attributes and a stale-ID guard.

Confidence Score: 4/5

Safe to merge with minor polish — the new endpoint correctly validates account types against QBO and strips sensitive fields before responding.

The API and service layers are well-guarded: type validation against QBO, tenant scoping via workspaceId, and a SafePortalConnectionSchema allowlist on the response. The main gap is on the frontend — submit failures are caught and logged but no error state is returned to the UI, so users get no feedback when a PATCH fails. There is also a duplicate AccountOption type definition across two files. Neither of these affects correctness of the data path.

src/hook/useSettings.ts — submit error handling and AccountOption duplication; src/type/common.ts — duplicate AccountOption definition that could drift from the hook's copy

Important Files Changed

Filename	Overview
src/app/api/quickbooks/accounts/accounts.controller.ts	New controller; uses SafePortalConnectionSchema.pick() to strip sensitive token fields from the PATCH response, and delegates to AccountService / TokenService correctly.
src/app/api/quickbooks/accounts/accounts.service.ts	New AccountService; maps QBAccountRowType to {id,name} before returning — no sensitive fields exposed. Error handling on missing portal connection is correct.
src/app/api/quickbooks/token/token.service.ts	Adds updateAccountRefs; validates each ref's AccountType against QBO before writing, with tenant scoping via workspaceId WHERE clause. Payload is parsed twice (controller + service) — redundant but harmless defensive pattern.
src/hook/useSettings.ts	Adds useOtherSettings; SWR fetch correctly skipped when disconnected. Submit errors are caught but only logged — no error state is propagated to the UI. AccountOption type is defined locally but is identical to the one in common.ts.
src/components/dashboard/settings/SettingAccordion.tsx	Adds Other Settings accordion entry; button rendering uses hardcoded index === 2, consistent with existing index === 0/1 pattern for other sections.
src/components/dashboard/settings/sections/other/OtherSettings.tsx	New AccountSelect dropdown component; handles disconnected/loading/error/empty states, includes ARIA attributes, and guards against stale IDs with a 'no longer in QuickBooks' label.
src/utils/intuitAPI.ts	Adds _getAccountsForProductMapping with three parallel QBO queries; bound without wrapWithRetry because inner customQuery calls already retry. Income query adds AccountSubType to SELECT correctly.
src/type/common.ts	Adds AccountOption, AccountsListResponse, and AccountRefsUpdateSchema; AccountOption is also re-declared in useSettings.ts (duplication).

Sequence Diagram

sequenceDiagram
    participant UI as OtherSettings (UI)
    participant Hook as useOtherSettings
    participant GETAPI as GET /api/quickbooks/accounts
    participant PATCHAPI as PATCH /api/quickbooks/accounts
    participant AS as AccountService
    participant TS as TokenService
    participant DB as QBPortalConnection (DB)
    participant QBO as QuickBooks API

    UI->>Hook: mount (checks syncFlag + portalConnectionStatus)
    Hook->>GETAPI: SWR fetch (authenticated)
    GETAPI->>AS: listAccountsForProductMapping()
    AS->>DB: getPortalTokens(workspaceId)
    DB-->>AS: connection row with current refs
    AS->>QBO: 3x customQuery (Income / Expense / Bank)
    QBO-->>AS: account rows per bucket
    AS-->>GETAPI: options + selected refs
    GETAPI-->>Hook: JSON (no secret fields)
    Hook-->>UI: options + settingState

    UI->>Hook: user selects account
    UI->>Hook: submit
    Hook->>PATCHAPI: PATCH changed fields only
    PATCHAPI->>TS: updateAccountRefs(payload)
    TS->>DB: getPortalTokens(workspaceId)
    TS->>QBO: getAnAccount() per changed ref
    QBO-->>TS: account rows
    TS->>TS: assert AccountType matches expected bucket
    TS->>DB: "updateQBPortalConnection WHERE portalId=workspaceId"
    DB-->>TS: updated row
    TS-->>PATCHAPI: full connection row
    PATCHAPI->>PATCHAPI: SafePortalConnectionSchema strips secrets
    PATCHAPI-->>Hook: safe portalConnection object
    Hook->>Hook: mutate SWR cache + update initialState

Loading

_{Reviews (1): Last reviewed commit: "fix(OUT-3275): address pre-push review" | Re-trigger Greptile}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
quickbooks-sync (dev)	Ready	Preview, Comment	May 22, 2026 5:36am