Skip to content

Detect more Minecraft version requirement forms in Fabric mods - #195

Merged
pavog merged 1 commit into
masterfrom
fabric-minecraft-version-range
Nov 13, 2026
Merged

pavog merged 1 commit into
masterfrom
fabric-minecraft-version-range

Conversation

@pavog

@pavog pavog commented Nov 13, 2026 •

Copy link
Copy Markdown
Member
- Mod 'Foo3' (foovcany) 1.0.0 requires any 1.x version of 'Minecraft' (minecraft), but only the wrong version is present: 26.3!
- Mod 'Foo4' (foovcmax) 1.0.0 requires version 26.1 or earlier of 'Minecraft' (minecraft), but only the wrong version is present: 26.3!
- Mod 'Foo5' (foovclist) 1.0.0 requires version 26.1 or version 26.2 of 'Minecraft' (minecraft), but only the wrong version is present: 26.3!

Fabric Loader words a Minecraft version requirement depending on how the mod declares it in its fabric.mod.json.
FabricModIncompatibleMinecraftVersionProblem only knew any version, or later, after, before, a single version and between.
Requirements written as a wildcard (1.x), an upper bound (<=26.1) or a list (["26.1", "26.2"]) were not detected at all.

This PR adds one pattern for each of these forms.
The solution suggests the required Minecraft version in the same notation (1.x, <=26.1, 26.1 or 26.2) and a different version of the mod, like the existing patterns do.

The loader lists three or more versions as version 26.1, version 26.2 or version 26.3; the list pattern covers that as well.
A tilde requirement like ~26.1 is not a new form: the loader prints it as any version between 26.1 (inclusive) and 26.2- (exclusive), which between already matches.

Changes

  • add the patterns wildcard, maximum and list to FabricModIncompatibleMinecraftVersionProblem
  • add the fixture fabric-minecraft-version-range.log, a real Fabric Loader 0.20.1 server log for Minecraft 26.3 with one mod per requirement form

@pavog pavog changed the title detect more Minecraft version requirement forms in Fabric mods Detect more Minecraft version requirement forms in Fabric mods Nov 13, 2026
@pavog
pavog requested a review from JulianVennen November 13, 2026 19:36
@pavog
pavog merged commit be7820b into master Nov 13, 2026
3 checks passed
@pavog
pavog deleted the fabric-minecraft-version-range branch November 13, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants