Repository navigation
Detect Fabric mods that require a newer Fabric Loader - #197
Merged
Merged
Conversation
JulianVennen
approved these changes
Nov 13, 2026
# Conflicts: # lang/en.json # src/Analyser/FabricAnalyser.php # src/Analysis/Problem/Fabric/FabricModDependencyProblem.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fabric Loader is a built-in mod with the id
fabricloader, so a mod that needs a newer loader is reported like a missing mod dependency.This happens regularly after a Fabric API update raises the minimum loader version.
FabricModDependencyProblemmatched that line and reported "The mod 'Foo' is missing the required mod 'Fabric Loader'." with the solution "Install the mod 'Fabric Loader' with version >=99.0.0.".The loader is part of the installation and not a file in the mods folder, so it has to be updated instead.
This PR adds
FabricLoaderVersionProblem, which names the mod, the required and the installed loader version, and the newFabricLoaderUpdateSolution("Update Fabric Loader to version 99.0.0 or later.").FabricModDependencyProblemskips dependencies onfabricloader, so the line is not reported twice.The pattern anchors on the id
(fabricloader), and on themodprefix the loader prints for it (unlike thejavaandminecraftbuilt-ins).An exact requirement (
requires version 0.17.3 of) is reported the same way, because in practice it means the installed loader is too old.Changes
FabricLoaderVersionProblemwith the patternsminimumandspecificFabricLoaderUpdateSolutionmod-fabric-loader-version-problemandfabric-loader-update-solutionFabricModDependencyProblemfabric-loader-outdated.log, a real Fabric Loader 0.20.1 server log for Minecraft 26.3Not covered:
any version before,afterandbetweenrequirements on the loader, which are rare.