Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChunkLoadExceptionProblemsearched the stack trace below "Encountered an unexpected exception" with(\n.*)*at.*.The nested quantifiers backtrack per character, so on entries of about 1 MB the patterns hit the backtrack or JIT stack limit and the problem was silently not detected.
This PR skips whole lines possessively with
(?:.*+\n)*?, so there is one backtracking point per line instead of per character.The cause line is matched from its start: a stack trace line (
\h*atfollowed by the package) or the exception chain before "Exception generating new chunk".Without that,
.*at.*still backtracked within every line, which failed without PCRE JIT.The fragments are constants with examples, because they are used in three patterns.
Changes
UNEXPECTED_EXCEPTIONandSTACK_TRACE_PACKAGEtoChunkLoadExceptionProblemChunkLoadExceptionProblemfromKNOWN_UNSAFE_PATTERNS