Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
loading-failed-exceptionpattern ofModDependencyProblemskipped lines with(?:.*\n)*, which hits the JIT stack limit on entries of about 1 MB, so the missing dependency wasn't reported.This PR makes the line possessive (
.*+), so backtracking happens per line instead of per character.The outer repetition stays greedy on purpose: a lazy one would report the first instead of the last dependency in the list and change existing results.
Knowingly not covered: only one dependency of the list is reported, that's a separate change.
Changes
ModDependencyProblemKNOWN_UNSAFE_PATTERNS