Repository navigation
Regenerate legacy plugin conversion fixture for the Bukkit console prefix - #202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#189 added
paper-legacy-plugin-conversion-26-3.logwith its expected output generated before #191 was merged.#191 parses the console prefix
[16:24:27 INFO]:on Bukkit servers, so this log is now split into separate entries instead of one entry for the whole log.Both PRs passed on their own, but master failed after merging both.
This PR only regenerates the expected output with
composer generate-tests.The
LegacyPluginConversionProblemis still detected with the same message and solutions.Its entry is now the ERROR entry with the stack trace (level 3) instead of the whole log as one INFO entry (level 6).
Changes
paper-legacy-plugin-conversion-26-3.json