Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #36
When
preg_match_all()returnedfalse, for example because a pattern exceeded the backtrack limit,PatternAnalysertreated it like a pattern that doesn't match.Such a pattern silently never found its problem, and nothing showed that it was broken.
findMatches()now triggers anE_USER_WARNINGthat names the pattern and the reason.For example:
The pattern is still treated as not matching, so the rest of the log is analysed as before.
This builds on #36, because the check lives in
findMatches().Decisions
false, and one failing pattern should not stop the analysis of the whole log.findMatches()only knows the pattern and the text.Only this one contains the pattern.
Changes
PatternAnalyser::findMatches()whenpreg_match_all()failsNot covered
failOnWarning.Their current test logs don't trigger it.