Repository navigation
chore: remove legacy Matlab-based OEM test and its build machinery - #1185
Merged
Merged
Conversation
The Matlab/atmlab-based OEM test integration is dead: the .m scripts were removed in the Lm merge, timings.cc was never tracked, and the configure-time FILE(COPY) of the missing scripts broke configuration whenever MATLABDIR/ATMLABDIR were set. - Drop the MATLABDIR/ATMLABDIR/CSHFOUND block and the broken test_oem target from src/tests/CMakeLists.txt - Delete src/tests/test_oem.cc, the only consumer of the Matlab engine API; coverage lives on in test_oem_methods.cc - Drop stale Matlab mention from the test_oem_methods comment
The dev.oem guide still pointed readers at the legacy src/tests/test_oem.cc, which no longer exists. State instead that the workspace-interface OEM tests have no optional external dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the last remnants of the old Matlab/Atmlab-based OEM test infrastructure, which has been dead code for years. The legacy
test_oemtarget required a local Matlab install, Atmlab, andcshto be configured via CMake cache variables, and it referenced Matlab script files that no longer exist in the repository (#1183) — so it could not actually be built or run in any current setup. OEM is now fully covered by the dependency-free, deterministic workspace-interface regressions intest_oem_methods, so nothing is lost in coverage.Changes
src/tests/test_oem.cc: Deleted the 2015-era OEM test (991 lines) that drove the OEM functions through the Matlab Engine API (engine.h) and Atmlab. It was only conditionally compiled whenMATLABDIR,ATMLABDIR, andcshwere all present.src/tests/CMakeLists.txt: Removed the entire conditionaltest_oembuild block, including theMATLABDIR/ATMLABDIRcache options,cshdetection, Matlab engine library lookup (libeng/libmx), Matlab interface macros, and the copy step for.mtest scripts (which are no longer in the repo). Also dropped the now-obsolete "independent of Matlab" comment on thetest_oem_methodstarget.doc/arts/dev.oem.rst: Dropped the reference to the removed legacy invlib-level Matlab tests, rewording the note to state that the OEM tests run without any optional external dependencies.src/tests/test_oem_methods.cc: Updated a comment to remove the stale mention of a Matlab installation.Breaking Changes
MATLABDIR/ATMLABDIRand expect thetest_oemCTest target will no longer find it. No replacement is needed —test_oem_methodsalready covers the OEM methods without external dependencies.