Add libnat20 as buildroot package to the linux example.#103
Draft
werwurm wants to merge 1 commit into
Draft
Conversation
This adds libnat20 to the example buildroot environment. It is a dependency for developing nat20 userspace tools.
LCOV of commit
|
There was a problem hiding this comment.
Pull request overview
This PR adds a Buildroot package for the libnat20 userspace library to the examples/linux Buildroot external tree, enabling it in the QEMU example config and exercising its build in CI to support development of nat20 userspace tooling.
Changes:
- Add a new Buildroot
libnat20CMake package (Config.in + .mk) and source it from the external tree. - Enable
BR2_PACKAGE_LIBNAT20in the QEMU Buildroot defconfig and extendbrrebuild allto rebuild it. - Update the GitHub Actions workflow to build and verify the libnat20 static archive.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/linux/br_external/utils/envsetup.sh | Adds libnat20 to brrebuild targets and to the all rebuild sequence. |
| examples/linux/br_external/package/libnat20/libnat20.mk | Introduces the Buildroot package definition for building/installing libnat20 via CMake. |
| examples/linux/br_external/package/libnat20/Config.in | Adds the Buildroot Kconfig entry for selecting libnat20. |
| examples/linux/br_external/configs/qemu_br_defconfig | Enables the new Buildroot package in the QEMU example configuration. |
| examples/linux/br_external/Config.in | Sources the new package’s Config.in so it appears in Buildroot menus. |
| .github/workflows/linux-kmod-build.yml | Builds libnat20 in CI and verifies libnat20.a is produced. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
83
to
86
| case "$1" in | ||
| all) | ||
| ensure_popd make linux-rebuild nat20crypto-rebuild nat20device-rebuild nat20sw-rebuild nat20lib-rebuild all | ||
| ensure_popd make linux-rebuild nat20crypto-rebuild libnat20-rebuild nat20device-rebuild nat20sw-rebuild nat20lib-rebuild all | ||
| ;; |
| LIBNAT20_LICENSE = Apache-2.0 OR GPL-2.0 | ||
| LIBNAT20_LICENSE_FILES = LICENSE-Apache-2.0.txt LICENSE-GPL-2.0.txt | ||
|
|
||
| LIBNAT20_INSTALL_STAGING = YES |
| # You should have received a copy of the GNU General Public License | ||
| # along with this program; if not, see | ||
| # <https://www.gnu.org/licenses/>. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds libnat20 to the example buildroot environment.
It is a dependency for developing nat20 userspace tools.