Feat: Removing deprecated endpoints#220
Merged
tanya732 merged 3 commits intojava-mvc-v2from Apr 29, 2026
Merged
Conversation
Contributor
Author
kailash-b
approved these changes
Apr 29, 2026
| * @param redirectUri the url to redirect to after authentication | ||
| * @param responseType the response type to use | ||
| */ | ||
| AuthorizeUrl(AuthAPI client, HttpServletRequest request, HttpServletResponse response, String redirectUri, String responseType) { |
There was a problem hiding this comment.
Given the request assignment is removed, is the HttpServletRequest request parameter still required?
Contributor
Author
There was a problem hiding this comment.
Yes, I have updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The PR has following changes -
(handle(request),buildAuthorizeUrl(request, redirectUri))References
Please include relevant links supporting this change such as a:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist