Adsk Contrib - Various improvements suggested by Claude#37
Adsk Contrib - Various improvements suggested by Claude#37doug-walker wants to merge 11 commits into
Conversation
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
cozdas
left a comment
cozdas
left a comment
There was a problem hiding this comment.
Looks good, I noted few minor issues.
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
KevinJW
left a comment
KevinJW
left a comment
There was a problem hiding this comment.
Just a quick read through of the diffs, did not compile or test
remia
left a comment
remia
left a comment
There was a problem hiding this comment.
Seems like this found quite a few issues nice to see!
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
| { | ||
|
|
||
| // Maximum number of entries supported in a 1D LUT. | ||
| constexpr unsigned long Max1DLUTLength = 300000; |
There was a problem hiding this comment.
Just a note, I've been looking elsewhere at the code and how we handle the 'size' of things, we may want to use size_t here and use '300000UL'.
If we turn up the warning level we have a lot of signed/unsigned and implicit conversions.
There was a problem hiding this comment.
Kevin, I tried compiling in clang with "-Wconversion -Wsign-conversion -Wfloat-conversion".
It generates thousands of warnings (just using "-Wall -Wextra" produces no warnings). I searched through these but did not find any for Max1DLUTLength or Max3DLUTLength.
But given that we never convert this constant to anything less than a 32-bit quantity, I don't believe there is a risk of a type conversion causing undesired behavior. Therefore, I will proceed with moving this PR to the main repo.
If you have specific fixes you'd like to propose, please continue to post here and I will make them in the final PR.
There was a problem hiding this comment.
@KevinJW, Note: I did make a slight change to avoid being flagged by "-Wold-style-cast", if that was what you were seeing.
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
…#2304) Signed-off-by: Rémi Achard <remiachard@gmail.com>
…Foundation#2281) * Fix OpenGL ES type issues in ACES2 FixedFunction Ops Signed-off-by: Rémi Achard <remiachard@gmail.com> * Update src/OpenColorIO/ops/fixedfunction/FixedFunctionOpGPU.cpp Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Rémi Achard <remiachard@gmail.com> * Add 2D texture path tests for ACES2 cusp and reach table sampling Signed-off-by: Rémi Achard <remiachard@gmail.com> --------- Signed-off-by: Rémi Achard <remiachard@gmail.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
4 participants
No description provided.