Refactor NodeBLSMappings weight APIs to use uint64#380
Closed
samliok wants to merge 2 commits into
Closed
Conversation
Change TotalWeight to return uint64 instead of int64, and replace ApprovingWeight (returning a single summed weight) with ApprovingWeights, which returns the per-node weight slice. This lets callers compute thresholds without an intermediate int64 conversion.
yacovm
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeBLSMappings.TotalWeight()now returnsuint64instead ofint64. The internal overflow check againstmath.MaxInt64is preserved.ApprovingWeight(which returned a single summedint64) is replaced byApprovingWeights, which returns the per-node[]uint64slice. This lets callers run their own threshold logic without bouncing throughint64.