fix(graphql-types-generator): remove babel 6 runtime chain#1012
Open
michaelgiraldo wants to merge 1 commit into
Open
fix(graphql-types-generator): remove babel 6 runtime chain#1012michaelgiraldo wants to merge 1 commit into
michaelgiraldo wants to merge 1 commit into
Conversation
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Babel 6 runtime chain and
rimraf@3from@aws-amplify/graphql-types-generator.This addresses the
graphql-types-generatorsubset of aws-amplify/amplify-backend#3062 and overlaps the broader fresh-install issue in aws-amplify/amplify-backend#3135.Changes
babel-generator@6/babel-types@6usage with@babel/generator/@babel/types@babel/*alias declaration files undersrc/flow-modern/typesrimrafusage withfs-extrain runtime and package scriptsGenericTypeAnnotation.idStrategy
The deprecated chain here was not just a version bump problem. The package still carried direct Babel 6 dependencies (
babel-generator,babel-types) andrimraf@3, while also pulling in Babel 7 APIs. During the migration, the real type issue turned out to be duplicate@babel/typesidentities in the workspace, not missing types. This patch aligns the Babel packages, removes the old alias shims, and keeps the fix on the package that actually owns this dependency chain.Verification
npx -y yarn@1.22.22 workspace @aws-amplify/graphql-types-generator buildnpx -y yarn@1.22.22 workspace @aws-amplify/graphql-types-generator test --runInBand@aws-amplify/model-generator@1.2.2showed:babel-generator@6.26.1 -> babel-runtime@6.26.0 -> core-js@2.6.12rimraf@3.0.2babel-generatorbabel-runtimerimrafcore-js@3.49.0only under@aws-amplify/graphql-types-generatorMaintainer Context
This PR is the first narrow package-owned slice of the deprecated dependency chain tracked in aws-amplify/amplify-backend#3062.
The companion PR #1013 addresses the separate
@aws-amplify/appsync-modelgen-plugin -> relay-compiler@12 -> glob@7 -> inflightpath. Together, those two PRs cover the mainamplify-codegen-owned subtrees from the current repro.Maintainer Ask
If this approach looks acceptable, please review this as an independent
graphql-types-generatorfix. Once merged and released, downstream repos can consume the published package and re-measure the broader fresh-install impact.