Repository navigation
test(distributed): xfail TestTraceableCollectives Neuron tests that copy across devices - #1030
Closed
tdalmia-aws wants to merge 1 commit into
Closed
tdalmia-aws wants to merge 1 commit into
tdalmia-aws wants to merge 1 commit into
Conversation
tdalmia-aws
marked this pull request as ready for review
November 2, 2026 21:18
…opy across devices The threaded process group copies tensors between Neuron devices. A cross-device copy keeps the result on the source device (aws-neuron#1021), so 7 TestTraceableCollectives tests fail in the nightly distributed job. Mark them as xfail until the copy fix ships.
tdalmia-aws
force-pushed
the
fix/cross-device-copy-1021
branch
from
November 2, 2026 21:55
9fc4dd7 to
4859dd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks the 7
TestTraceableCollectivesNeuron tests that fail in the nightlydistributedjob as xfail.Related Issue
Related to #1021
Motivation and Context
The threaded process group in these tests copies tensors between Neuron devices, and a cross-device copy currently keeps the result on the source device (#1021). The tests fail with
Inconsistent device IDs found in kernel outputs: expected device 0 but found device 1, which keeps the nightly red: https://github.com/aws-neuron/torch-neuronx/actions/runs/41279502191The copy fix will come with the next release. Until then these are xfail (not strict), so they report as xpass once the fix lands.
Type of Change
Test-only change: skip registry entries.
Testing
Ran locally (no Neuron hardware needed):
All hooks pass.
Ran on Neuron hardware:
On main these 7 fail with the error above, the same as the nightly. The xfail entries cover exactly those 7 tests.
Checklist