fix(event-handler): correct InvalidHttpMethodError name#5254
Open
svozza wants to merge 5 commits into
Open
Conversation
powertools-for-aws-oss-automation
Bot
added
size/M
InvalidHttpMethodError's constructor set this.name to 'InvalidEventError' (copy-paste from the sibling class above it). Name-based dispatch in ErrorHandlerRegistry.resolve would mis-route the method error to an InvalidEventError handler. Fixes #5251.
Removes the ErrorHandlerRegistry test asserting InvalidHttpMethodError is not routed to an InvalidEventError handler via name-fallback. The errors.test.ts and converters.test.ts coverage already pins the .name fix; this registry-level test is redundant.
svozza
force-pushed
the
fix/event-handler-invalid-http-method-error-name
branch
from
e4e58c9 to
adc0e70
Compare
powertools-for-aws-oss-automation
Bot
added
size/M
powertools-for-aws-oss-automation
Bot
added
size/M
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidHttpMethodError's constructor incorrectly setthis.name = 'InvalidEventError'(a copy-paste from the sibling class declared just above it inerrors.ts). Two distinct error classes shared the samename, breaking the name-based dispatch fallback inErrorHandlerRegistry.resolve(the third resolution step used as a safety net for cross-module/bundling scenarios whereinstanceofmay fail) — anInvalidHttpMethodErrorwould route to a handler registered forInvalidEventError.Changes
InvalidHttpMethodErrorto setthis.name = 'InvalidHttpMethodError'inpackages/event-handler/src/http/errors.ts.InvalidEventErrorandInvalidHttpMethodErrorintests/unit/http/errors.test.ts(asserting.name,.message, andinstanceoffor each).it.eachintests/unit/http/errors.test.tsto asserterror.name === errorTypefor everyHttpErrorsubclass — guards all 9 of them against the same copy-paste class of bug.tests/unit/http/converters.test.tsfor the previously-unexercised unsupported-method branch inproxyEventToWebRequest, parametrised over API Gateway V1, V2, and ALB events. Asserts bothinstanceof InvalidHttpMethodErroranderr.name === 'InvalidHttpMethodError'(the.namecheck is load-bearing —toThrow(Class)alone would still pass with the bug present).Issue number: closes #5251
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.