fix(event-handler): normalize trailing slashes in HTTP Router prefix joining#5255
Open
svozza wants to merge 3 commits into
Open
fix(event-handler): normalize trailing slashes in HTTP Router prefix joining#5255svozza wants to merge 3 commits into
svozza wants to merge 3 commits into
Conversation
…HTTP Router resolvePrefixedPath now strips trailing slashes off the prefix before joining, preventing double slashes when prefix already ends with `/`. Router.resolve normalizes incoming request paths the same way (preserving `/` itself) so a route registered with path `/` under prefix `/api` matches both `/api` and `/api/`. Closes #5252
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Replace `replace(/\/+$/, '')` with a small `stripTrailingSlashes` helper that walks the string from the end, keeping path normalization linear in input length.
powertools-for-aws-oss-automation
Bot
added
size/M
powertools-for-aws-oss-automation
Bot
added
size/M
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routerregistered route ids did not handle trailing slashes consistently: a root route under a prefix (e.g.app.get('/', …)withprefix: '/api') was unreachable from/api/, and a prefix that accidentally ended with/produced double slashes in the route id (e.g.'/api//users'), breaking matches.Changes
resolvePrefixedPathnow strips trailing slashes from the prefix before joining, so'/api'and'/api/'produce the same result and no//appears in the route id.Router.resolvenormalizes incoming request paths the same way (preserving/itself), so a route registered as/under prefix/apimatches both/apiand/api/.resolvePrefixedPathcovering prefix-with-trailing-slash inputs, and integration tests inbasic-routing.test.tsfor both bug scenarios from the issue.resolvePrefixedPathJSDoc to document the normalization preconditions.Issue number: closes #5252
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.