fix: new pooled connections created with stale password#1231
Open
fix: new pooled connections created with stale password#1231
Conversation
sophia-bq
approved these changes
May 6, 2026
| error_msg: str = error.args[0] | ||
| return any(error_msg.startswith(msg) for msg in self._NETWORK_ERROR_MESSAGES) | ||
| is_network_error: bool = any(error_msg.startswith(msg) for msg in self._NETWORK_ERROR_MESSAGES) | ||
| # PAM errors may be nested in the connection error, double check here to avoid false positives |
Contributor
There was a problem hiding this comment.
I feel like this should say "the connection error messages" or "a connection error"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Address the two issues raised in #1230
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.