chore(toolkit-lib): recommend to use drift aware change sets when deploying to Cloudformation after hotswapping#1467
Merged
aws-cdk-automation merged 8 commits intomainfrom May 4, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 74 74
Lines 10669 10669
Branches 1457 1457
=======================================
Hits 9400 9400
Misses 1241 1241
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 3 commits
May 1, 2026 16:13
rix0rrr
reviewed
May 4, 2026
| ); | ||
|
|
||
| if (hotswapDeploymentResult) { | ||
| if (deploymentMethod.fallback) { |
Contributor
There was a problem hiding this comment.
This is true even if we never do the fallback ourselves.
As soon as we hotswap we have introduced drift, and we should print "next non-hotsweap deployment should include --revert-drift".
Contributor
There was a problem hiding this comment.
If we do a fallback deployment WITHOUT --revert-drift, then that's an entirely different problem :D
rix0rrr
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drift aware change sets take into account current resource state when making a changeset and will not make changes if the new template and the resource state align, otherwise will prefer changes from the new template.
When recovering from hotswap deployments, drift aware changesets will do a better job of getting your Cloudformation state and your current resource state back into sync than a regular Cloudformation deployment (using changesets or update stack) would. Adds a message in the CLI that recommends to use drift aware changesets when deploying to Cloudformation after performing hotswap deployments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license